@blueorangutan package

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✔centos6 ✔centos7 ✖debian. JID-2347

@blueorangutan package

@rafaelweingartner a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2352

@blueorangutan test

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

Trillian test result (tid-3082)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 25023 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2893-t3082-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_multipleips_per_nic.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
Smoke tests completed. 67 look OK, 2 have error(s)
Only failed tests results shown below:

@blueorangutan test

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan test

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan package

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✔centos6 ✖centos7 ✖debian. JID-2382

@blueorangutan package

@DaanHoogland sorry lab's down, BO queue will be stuck for a while.

@blueorangutan package

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✖centos6 ✔centos7 ✔debian. JID-2395

@blueorangutan package

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2396

@blueorangutan test

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

Trillian test result (tid-3135)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 23046 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2893-t3135-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_multipleips_per_nic.py
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_host_maintenance.py
Smoke tests completed. 66 look OK, 3 have error(s)
Only failed tests results shown below:

@DaanHoogland @rhtyd @greut
Unit-tests buggy. Take a look:

@Test
    public void zonedTimeFormatIsoNoColonZMs() throws ParseException {
        Date time = new Date();
        DateTimeFormatter formatter = DateTimeFormatter.ofPattern("yyyy-MM-dd'T'HH:mm:ss.SSSSSSZ");
        String str = OffsetDateTime.now().format(formatter);

        Date dtParsed = DateUtil.parseTZDateString(str);

        assertEquals(str, time.toString(), dtParsed.toString());
    }

This unittest is obviously buggy. Because there are two times when objects are used to get current DT, as a result, sometimes it fails.

https://travis-ci.org/apache/cloudstack/jobs/450628551#L1047

Need a codefix or PR reverted and fixed. PR was merged recently. Now CS fails to build sometimes.

Other tests in this PR also must be revised on similar behaviors.

@bwsw You are right that these tests depend on hwclocktime and are not reliable. Any sugestions on how to fix without losing test-validity?

@bwsw a quick hack of mine:

    @Test
    public void zonedTimeFormatIsoNoColonZMs() throws ParseException {
        Date time = new Date();
        DateTimeFormatter formatter = DateTimeFormatter.ofPattern("yyyy-MM-dd'T'HH:mm:ss.SSSSSSZ");
        String str = OffsetDateTime.of(time.getYear(),time.getMonth(),time.getDay(),time.getHours(),time.getMinutes(),time.getSeconds(),0,ZoneOffset.ofHours(time.getTimezoneOffset())).format(formatter);

        Date dtParsed = DateUtil.parseTZDateString(str);

        assertEquals(str, time.toString(), dtParsed.toString());
    }

ugly quick hack but should almost do what is intended without losing test quality or time skew bug as you reported. not sure how the nanoseconds must be handled yet.
thoughts?

@DaanHoogland Looks good to me. May be imperfect, but should work, at least.

well @bwsw the code needs debugging still.

strangely this works:

    @Test
    public void zonedTimeFormatIsoNoColonZMs() throws ParseException {
        Date time = new Date();
        DateTimeFormatter formatter = DateTimeFormatter.ofPattern("yyyy-MM-dd'T'HH:mm:ss.SSSSSSZ");
        String str = OffsetDateTime.of(time.getYear()+1900,time.getMonth()+1,time.getDate(),time.getHours(),time.getMinutes(),time.getSeconds(),0,ZoneOffset.ofHours(-1*time.getTimezoneOffset()/60)).format(formatter);

        Date dtParsed = DateUtil.parseTZDateString(str);

        assertEquals(str, time.toString(), dtParsed.toString());
    }

not sure if it is valid in all cases though, can you test @bwsw
@nvazquez could you test from the western hemisphere, please?

Tested on latest master: first tested running every test and passed successfully. Then replaced the last one for the code @DaanHoogland provided above and also succeeded

@DaanHoogland
@nvazquez
There are five tests like the one above in that unit test module. All of them must be reworked. I think it's either to revert PR or to open a separate issue for fixing each of them.

@bwsw #3003 contains what I think is enough, let's discuss further overthere